Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/671
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129720549
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
Looks Good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129398162
Looks Good to me.
Probably remove_nic might return an error if the NIC is not removed , but
just wondering if a check is needed in the below step , to val
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129378007
Test to verify remove nic from vm if the nic ip is same as another vm ip in
another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS
===
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/671
CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
