Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1416#issuecomment-185092942
@remibergsma and @runseb Please give one LGTM to close the PR as it is
just the change in commit message and PR title .
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1416#issuecomment-185092625
please ask @remibergsma and @runseb , as they had opinions on it before.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1416#issuecomment-185092215
@DaanHoogland Please give one LGTM to close the PR as it is just the
change in commit message and PR title .
---
If your project is set up for it, you
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1416#issuecomment-185061120
LGTM based on PR #667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1411#issuecomment-185057058
I have reverted this merge commit
commit d159af93b4e6485b30424026e1a84ce85a3c7abf
Author: sanjeev
Date: Wed Feb 17 11:53:07 2016 +0530
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1416
CLOUDSTACK-8717: Failed to start instance after restoring the running
instance
Changing PR title and commit message
In continuation with PR #1411 and #667
You can merge this pull
@remibergsma, I did not notice that there were two commits in it. I only
looked at the modified content of the file.
Thanks for reverting it.
On Fri, Feb 12, 2016 at 1:00 AM, remibergsma wrote:
> Github user remibergsma commented on the pull request:
>
> https://github.com/apache/cloudstack/
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-183022736
Don't merge stuff without responding to the comments. Look at your commits,
two with the same title? How does that help? I asked to squash them on Aug 14
and now
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-182802497
LGTM !!
Test Restore VM on VMWare ... === TestName: test_01_recover_VM | Status :
SUCCESS ===
ok
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-182784773
LGTM ..based on code review and result .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-182778439
Testcase results:
Test Restore VM on VMWare ... === TestName: test_01_recover_VM | Status :
SUCCESS ===
ok
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-131213451
@pritisarap12 Same here, please squash the commits as they have the same
titles.
Also, please @nitt10prashant asks for tests results. Can you please post
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129837984
can we get test results ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36733719
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129836794
can we get test result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129310396
Updated testcase with review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36602070
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36601640
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/667
CLOUDSTACK-8717: Failed to start instance after restoring the running
instance
On setup with two cluster wide primary storage verify restoring a running
instance.(As while restoring insta
20 matches
Mail list logo
