[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/666#discussion_r36580162 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEve

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/666#discussion_r36576681 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEve

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/666#discussion_r36576679 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEve

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/666#discussion_r36527589 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEven

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/666#discussion_r36526622 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEven

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/666#issuecomment-128717347 LGTM from my super phone ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/666#issuecomment-128689198 @borisroman Thx, removed the redundant parentheses --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/666#issuecomment-128685143 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/666 CLOUDSTACK-8709 No out of band migrate alert for non-routers This prevents the out-of-band migrate alerts being generated for non-routers. You can merge this pull request into a Git reposit