[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150713484 This is far from done and i'll change the title to be prefixed with [wip] it is a crosscutting change the touches all internal communication of cloudstack. It i

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150648494 @DaanHoogland I have the same result as @borisroman reports: ``` Deploy DC Started Exception Occurred: ['Traceback (most recent call las

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-23 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150553777 @DaanHoogland Could you please have a look again? ``` WARN [c.c.a.m.AgentManagerImpl] (StatsCollector-1:ctx-94b6fe0e) Exception while sending java.lan

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-21 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-150010981 @DaanHoogland I tested this PR again today. When using the listSystemVms API call: ``` INFO [c.c.a.ApiServer] (1975058800@qtp-1945752215-4:ct

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-149816168 Thanks @rafaelweingartner , i'll look at your bit and merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-21 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r42595404 --- Diff: core/src/org/apache/cloudstack/agent/transport/AnswerArrayTypeAdaptor.java --- @@ -0,0 +1,33 @@ +package org.apache.cloudstack.agent.tr

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-20 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-149742333 @ DaanHoogland, I ran the tests from my Windows environments, after I did some work arounds everything started passing the tests. The fixes I did I cre

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-20 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r42564487 --- Diff: core/src/org/apache/cloudstack/agent/transport/AnswerArrayTypeAdaptor.java --- @@ -0,0 +1,33 @@ +package org.apache.cloudstack.age

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-149531857 @wido Will do! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-149531398 So, this PR is hard to test. For now I've verified that it compiles on my Ubuntu desktop with Java 8 and all the Unit Tests succeed, so that's good. Asking @bor

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/932#issuecomment-148722212 So far so good, all test passed in CI. This touches every command and answer that is serialized, however. please all test --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-15 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r42135300 --- Diff: pom.xml --- @@ -73,7 +73,7 @@ 1.9.2 1.0.0-build217 2.6.9 -1.7.2 +[2.4,) --- End diff --

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-14 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/932#discussion_r41998154 --- Diff: pom.xml --- @@ -73,7 +73,7 @@ 1.9.2 1.0.0-build217 2.6.9 -1.7.2 +[2.4,) --- End diff -- Our

[GitHub] cloudstack pull request: CLOUDSTACK-8708: gson update and ArrayTyp...

2015-10-14 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/932 CLOUDSTACK-8708: gson update and ArrayTypeAdaptor rewrite unit test for RequestTest is passing in eclipse. On macosx 10.11 using java 1.8 or 1.7 it fails from the command line. You can mer