Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/631
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
LGTM!!
On Mon, Aug 3, 2015 at 11:46 AM, pritisarap12 wrote:
> Github user pritisarap12 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/631#discussion_r36058447
>
> --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
> @@ -0,0
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r36058447
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35955307
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35955247
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,209 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/631#issuecomment-126605717
All is green and as there is no other reviews and all tests are green, I am
going to say: LGTM. But please someone that understands the full ramifications
of th
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35947714
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/631#discussion_r35743142
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/631#issuecomment-125875443
I can only judge this on code cleanliness. An added pep8 pull request
builder might help;) @pritisarap12 please solicit review from test experts that
have acces
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/631
CLOUDSTACK-8686:Verify data disk attachment for clusters with only zone
wide primary
-Attaching the uploaded/allocated volume to a VM on zwps
You can merge this pull request into a Git rep
10 matches
Mail list logo
