[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/634#issuecomment-125912564 @wilderrodrigues agreed. we can take it up as a new issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/634#issuecomment-125912381 LGTM :+1: @karuturi, should we perhaps create an issue to follow up on this? I think we should refactor the early-config a bit and, as you mentioned

[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/634#issuecomment-125910552 looks good :+1: but, should this processing be part of the setup_[router|vpcrouter|dhcpserver] itself? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/634#issuecomment-125895559 Awesome, @kishankavala! Will wait for the build/travis to vote/merge it. Cheers, Wilder --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-8683: process cmd_line.json fo...

2015-07-29 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/634 CLOUDSTACK-8683: process cmd_line.json for shared network VR in cloud-early-config - SSH access on link_local_ip is blocked for shared VR - MS is unable to program rules on VR. Vm deplo