Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/766
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137923198
No Travis test results? Both Apache builds are green and I verified the
function to work properly so merging it.
---
If your project is set up for it, you can r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137854742
LGTM Tested it, works great (even without single change to
agent.properties). It will reserve 1GB by default.
![before]
(http://s29.postimg.org/uoxtr
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137495603
@kmccormick thanks for the PR, will test it soon! Had a bit of a rough week
at the office with some emergencies going on.
Please rebase with current master,
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137243367
@kmccormick Agreed. A release note would be enough since running VMs will
not be affected.
CPU is a different problem indeed. Stuff becomes slow, but going Out
Github user kmccormick commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137155599
Regarding the upgrade scenario, I believe that this would not affect any
running VMs. Can anyone confirm? Besides just running VMs, it is still a
potential proble
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-137004807
What happens in case of an upgrade? Looks like there is a possibility that
the host may get over-provisioned. Should there be some scripts to let the user
know i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-136922701
LGTM, in case my previous comment is not already interpreted as such.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user kmccormick commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-136810812
OK, reworked this a bit. Removed dom0ram and using only _dom0MinMem now.
This line should cause a 1GB default if the value isn't specified in the
file:
Github user securityvoodoo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/766#discussion_r38436231
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -258,7 +258,7 @@
priva
Member variables of type int or long are auto initialized to 0 in Java (as
opposed to an unknown value).
That being said, that might not be a good default value for this situation.
On Tuesday, September 1, 2015, DaanHoogland wrote:
> Github user DaanHoogland commented on a diff in the pull requ
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/766#discussion_r38409667
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -258,7 +258,7 @@
private String
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/766#issuecomment-136632587
except for the initialisation issue, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/766#discussion_r38394939
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -258,7 +258,7 @@
private
GitHub user kmccormick opened a pull request:
https://github.com/apache/cloudstack/pull/766
CLOUDSTACK-8678: Reserve RAM for KVM host OS
Use host.reserved.ram.mb agent property to modify total system RAM
before reporting to management server.
You can merge this pull request into
15 matches
Mail list logo
