Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-212789349
This will probably never merge. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r53039381
--- Diff: server/src/org/apache/cloudstack/report/AtomicGsonAdapter.java ---
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-135369995
@bhaisaab Isn't it already a plug-in?
Don't know if the PR is the right way to discuss it, but I also want to
know how many Instances and cloud is running. So n
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-134922676
@wido can you implement this as a plugin instead of core feature? Also do
we want cloudstack to report statistics on each run; I suggest to have it as a
plugin with
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-132472682
@runseb Yes, indeed. But the PR is not ready to merge yet, it's blocked by
a GSON issue which I don't know how to resolve.
This is what @DaanHoogland found out:
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-132254920
This will be turned ON by default ?
I think you should bring this up on the list, at least to give a heads up
and an official public record.
---
If your project
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-131030515
I have create a issue regarding the new Gson version:
https://issues.apache.org/jira/browse/CLOUDSTACK-8708
---
If your project is set up for it, you can reply to this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-127927660
@DaanHoogland You are right. There has been a change between GSON 1.7 and
2.0 which causes a failure of the tests.
Looking into this, but my Java Reflecting kno
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-127384025
@wido I am pretty sure acs code has a problem with the new gson version
(see
https://builds.apache.org/job/cloudstack-pull-requests/872/org.apache.cloudstack$cl
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-127377070
I just don't know why the tests keep failing on this one. They seem to fail
on code not touched by this PR at all. Really want to get this in to 4.6.
---
If your proje
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126695290
@DaanHoogland I need 2.3.1 for this patch to work. It builds with 2.3.1,
but not with 1.7.2
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126691096
I confirmed the problem in the failing test is in the newer gson version.
Hope this works with the older gson. testing ... 1-2
---
If your project is set up fo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35971855
--- Diff: pom.xml ---
@@ -64,6 +64,7 @@
2.6.9
1.7.2
18.0
+2.3.1
--- End diff --
cs.gson.version is def
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126685792
let's find out. it might reveal some totally unrelated problem due to
I never saw the serialization tests before AFAIR but will look at them now ;)
---
If
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126684715
@DaanHoogland I see, but I'm not even getting near that code. So it's
unclear to me why this PR seems unstable.
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126677074
@wido not sure if these are related but please have a look at
https://builds.apache.org/job/cloudstack-pull-analysis/83/org.apache.cloudstack$cloud-core/testRepo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-126674015
I still don't know why travis fails. It fails on a storage part, but this
commit doesn't touch anything from the storage. So I can't see why.
---
If your project is se
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35954149
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT `fk_extern
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35948897
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT `fk_extern
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35655350
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,490 @@
+// Licensed to the Apache Software Foundation
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35649303
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,490 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35633526
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35627322
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35627154
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35626976
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35626289
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) un
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35625832
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35625883
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35625751
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35625795
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-125505835
@DaanHoogland I will. Although I don't understand why these are happening
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-125505270
@wido you are introducing two findbugs findings, can you look at those?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35606107
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35605842
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35605766
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35605790
--- Diff: reporter/usage-report-collector.py ---
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35605705
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,487 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35535873
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,473 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35534267
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,473 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35534192
--- Diff: server/src/org/apache/cloudstack/report/UsageReporter.java ---
@@ -0,0 +1,473 @@
+// Licensed to the Apache Software Foundation (ASF) under
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35533953
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT `fk_external_bigsw
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-125199454
any way to verify this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/625#discussion_r35532842
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -398,3 +398,5 @@ CREATE TABLE `cloud`.`external_bigswitch_bcf_devices` (
CONSTRAINT `fk_extern
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/625
CLOUDSTACK-8677: Call-home functionality for CloudStack
With this commit the Management Server will be default generate a anonymous
Usage
report every 7 (seven) days and submit this information
45 matches
Mail list logo
