[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-126196695 Awesome, thanks! Cheers, Wilder Sent from my iPhone On 30 Jul 2015, at 07:22, kishankavala mailto:notificati...@github.com>> wr

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-126186427 Hi @wilderrodrigues, @sanjeevneelarapu filed ticket for "default policy ACCEPT" issue. https://issues.apache.org/jira/browse/CLOUDSTACK-8688 --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125915603 Awesome! Thanks a lot, @karuturi and @kishankavala Cheers, Wilder --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125915281 Thanks @wilderrodrigues I merged https://github.com/apache/cloudstack/pull/634/ I'll created separate ticket to track "default policy ACCEPT" issue. -

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125894943 Hi @kishankavala Let's try to focus on 1 change at a time: 1. the port 3922 is blocked 2. default policy ACCEPT So, the changes

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125890106 @wilderrodrigues iptables issue is not specific to dhcpsrvr (shared VR). On isolated VR also default policy is ACCEPT ``` root@r-23-VM:~# iptables -L -nv

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125889027 Hi @kishankavala, If it doesn't match the content of rules.v4 perhaps the iptables-save is not being called when dhcpsrvr. By adding the cha

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125882216 Sure @wilderrodrigues I'll create a PR. But iptables rules are more open now (default ACCEPT). root@r-30-VM:~# iptables -L INPUT -nv Chain

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125878438 Nice catch, @kishankavala ! I checked the history of the file and found out that the changes for VPC router and normal router were added in the commi

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-29 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125864299 @wilderrodrigues Below changes fixed the issue but not sure if it breaks anything else: kk-cloudstack > git diff diff --git a/systemvm/patches/de

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125850427 Hi @kishankavala I'm on it. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125846995 Hi @wilderrodrigues Please look into CLOUDSTACK-8683 when possible --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125639101 Hi @kishankavala Are you looking at the other problem or can I have a look into it? I was able to reproduce here... just let me know if you

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125580306 Yes @wilderrodrigues "VR started successfully ". But port 3922 is not open. Once I add iptables rule to allow 3922, MS is able to program rules. I'm looking

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125572581 Hi @kishankavala But you said you tested "VR successfully started on shared network. All IPs are configured properly."... Based on that, I assumed i

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125571871 Thanks @wilderrodrigues for merging. Ran into another blocker after VR came up: https://issues.apache.org/jira/browse/CLOUDSTACK-8683 --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125566567 Thanks for the PR, @kishankavala ! It LGTM :+1: and I will also test it Cheers, Wilder --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/627#issuecomment-125565419 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared networ...

2015-07-28 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/627 CLOUDSTACK-8668: VR type in shared network is dhcpsrvr. Ips are being removed due to this issue - VR IP config is loaded from /var/cache/cloud/cmdline - For shared network VR type is "d