Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-125156829
@wilderrodrigues Agree that refactoring the code might help with the tests.
But that will be a bigger effort.
---
If your project is set up for it, you can repl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-12513
Hi @koushik-das
Perhaps refactoring the code in a way that its design is improved could
make easy to add tests for it.
---
If your project is set
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-125152445
@DaanHoogland Writing an unit test for changes in AgentManagerImpl.java is
hard due to the way the method gets invoked. Let me know if you have any
suggestion.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124584731
wasn't this needing (unit)-tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124357139
Merging it as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124323020
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124243179
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/621
CLOUDSTACK-8666: Put host in Alert state only after alert.wait timeout
Instead of putting the host to Alert state immediately, the investigators
should be allowed to run for some time based
