Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/850
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149862804
Sure, I think that a more specific âthrowsâ clause has to be used.
Throws exception, was just an expression.
---
If your project is set up for it, y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149862051
not "throws Exception" but a more specific throws. In this case the
exceptions are silently ignored as part of a happy flow. I don't like that but
I'm not goin
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149861633
If an exception occurs, is the test still going to pass?
If that is not the case, I would use "throws Exception" on each one of
those tests.
---
If y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149818277
the reason for ignoring should be made more explicit in one way or the
other. I'm not hellbound on logging but I see no problem in it. A caught and
ignored exce
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149744151
Do you guys really think that is a good idea to log exceptions in a test
case?
If the case is just to ignore them, it could be done without logging.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149162987
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-144384074
@DaanHoogland @borisroman The test needs to invoke a protected method from
a class and so is done using reflection. The test case already asserts for the
method
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-144363576
@borisroman the expeted attribute is not there and as I understand with
reason. The exceptions are part of the contract and need to be handled by the
client. Th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-141662154
@DaanHoogland Why log when an exception is thrown? In a test when an
exception is thrown it should either fail, or when @Test(expected =
--exception.class--) is d
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-141620583
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/850
CLOUDSTACK-8656: tests ignoring exceptions
final few ignored exceptions supplied with log messages.
You can merge this pull request into a Git repository by running:
$ git pull https:/
12 matches
Mail list logo
