Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123995530
Awesome @franklouwers ! Thanks for the details.
LGTM :+1: Merging...
---
If your project is set up for it, you can reply to this email and have your
Github user franklouwers commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123756479
See updated commit to fix the missing : .
See also https://gist.github.com/franklouwers/d5061b4ef50e2b4253fe with
logs of what works, what doesn't work,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123711497
@wilderrodrigues yeah, as I said I've not tested it. Just had a glance at
the code, but good that @resmo pointed out the typo.
---
If your project is set up for it
Github user franklouwers commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123706604
All,
I'll check the typo (I know how it happend) later this afternoon. Will also
provide logs both before (bad behaviour: rule not installed) and after
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123697692
@bhaisaab I was going to ask @franklouwers how did he test his changes,
since I would like to test them before giving a LGTM.
Actually, I think you w
Github user resmo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/601#discussion_r35187102
--- Diff: scripts/vm/network/security_group.py ---
@@ -860,8 +860,10 @@ def add_network_rules(vm_name, vm_id, vm_ip,
signature, seqno, vmMac, rules, vif
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/601#issuecomment-123526526
LGTM, though I've not tested this with a real host
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
