[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1305#issuecomment-216219986 Thanks @sarathkouk please rebase and push -f for travis to be kicked off advise how should we test, the default test case values are all empty --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2016-01-04 Thread sarathkouk
Github user sarathkouk commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-168668792 Closing this pull request and creating a new one as there were some problems encountered with current branch --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2016-01-04 Thread sarathkouk
Github user sarathkouk closed the pull request at: https://github.com/apache/cloudstack/pull/919 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-11-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-153049778 @sarathkouk Thanks, will look into it. Can you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-11-02 Thread sarathkouk
Github user sarathkouk commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-152976137 @remibergsma : Yes, it is. I made all the changes you suggested. Please go through and let me know if it looks good. --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-11-01 Thread sarathkouk
Github user sarathkouk commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-152932441 @remibergsma : Yes, it is. I made all the changes you suggested. Please go through and let me know if it looks good. --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/919#issuecomment-150837929 @sarathkouk For my understanding, is this the integration test for the feature @karuturi recently developed in #755 ? For the sake of it, please force pu

[GitHub] cloudstack pull request: CLOUDSTACK-8647 : LDAP: Auto Import and T...

2015-10-24 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/919#discussion_r42936389 --- Diff: test/integration/component/test_ldap_autoImport.py --- @@ -0,0 +1,663 @@ + +from marvin.cloudstackTestCase import cloudstackTestCase