Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121602562
squashed/merged your commits; in future please try to squash them as you
iterate with your reviews
---
If your project is set up for it, you can reply to this emai
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121602397
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
LGTM
On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 wrote:
> Github user pritisarap12 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/592#discussion_r34656988
>
> --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py
> ---
> @@ -0
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34656988
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) und
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/592#discussion_r34650908
--- Diff: test/integration/testpaths/testpath_custom_disk_offering.py ---
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/592#issuecomment-121511374
This description looks better, @pritisarap12 . I think you meant something
like that for your previous PR.
I will wait for the build/travis and vote
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/592
CLOUDSTACK-8636: Verify failure of creation of Custom disk offering with
disksize parameter
Custom disk creation should not take disksize parameter while creating the
disk offering
You ca
