Re: [GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread Sanjeev N
LGTM!! On Tue, Jul 14, 2015 at 5:08 PM, DaanHoogland wrote: > Github user DaanHoogland commented on the pull request: > > https://github.com/apache/cloudstack/pull/585#issuecomment-121211124 > > I agree with Sanju. please ammend to something like > CLOUDSTACK-8631: changing if condit

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121211124 I agree with Sanju. please ammend to something like CLOUDSTACK-8631: changing if condition to update to zero when needed --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121210527 its there in ticket On Tue, Jul 14, 2015 at 5:03 PM, sanju1010 wrote: > Can you please specify the reason for changing the if condition for t

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/585#issuecomment-121210285 Can you please specify the reason for changing the if condition for the benefit of others? --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: CLOUDSTACK-8631 :changing if condition in...

2015-07-14 Thread nitt10prashant
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/585 CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limit… test result Test Try to deploy VM with admin account where account has not used ... === TestName: