Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122237241
@wido thanks for the clarification. as said LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122236231
@DaanHoogland It is in the KVMFencer in the MGMT server. The Agent can't
send an alert, so I had to do this in the mgmt server.
---
If your project is set up for it, y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122235606
LGTM, how about the alert @bhaisaab asked for?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122234914
The tests have been fixed, Mocking issue in the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122016035
Indeed, I noticed that to late. Fixing the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-122015786
Travis failed due to NPE:
Tests in error:
KVMFencerTest.testWithFailingFence:135 » NullPointer
KVMFencerTest.testWithSingleHost:75 » Nu
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121967519
Working on a additional commit which brings in more logging and a unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121966201
@wido any news on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/580#discussion_r34755639
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtFenceCommandWrapper.java
---
@@ -48,6 +48,18 @@ public Answer exe
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/580#issuecomment-121512071
Hi @wido
Could you please add an extra test to cover the "pools.size() == 0)"?
Cheers,
Wilder
---
If your project is set up for it, yo
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/580
CLOUDSTACK-8628: kvm: Disable Fencing when no NFS storage pools are pâ¦
â¦resent
On NFS we write a heartbeat, but without those we can not safely
fence off a host.
If we fenc
12 matches
Mail list logo
