Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120396037
Thanks for the reviews, merged on 4.5/master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120276323
LGTM be sure to add 2 'this closes #' lines. one for this and one for 308
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120256667
"page refreshes, opening
multiple tabs,"
Nice!
I also liked the String.format() calls. I should use it more as well. For
some stuff stil
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120215440
This was much needed. The code looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120146710
(note: single patch ensures we capture the single aim with this fix and
also easy to port to other branches, 4.5/master etc.)
---
If your project is set up for it,
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/574#issuecomment-120146560
I reviewed https://github.com/apache/cloudstack/pull/308 and found that it
needs more fixes, since that PR is slightly old now, worked on this. This aims
to have a
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/574
CLOUDSTACK-8622: Reinstate working sessions in browser
- Login is based on sessionkey HttpOnly Cookie
- ApiServlet does login verification using sessionKey from both the request
cookies
