Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/587#issuecomment-121928006
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34771180
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y --fo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34770678
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y --force
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/587#issuecomment-121827701
LGTM, though did not test it due to lack of time and test infrastructure.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34755507
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
@@ -35,10 +35,9 @@ def load(self):
self.new_config.append(lin
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34589895
--- Diff:
systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ ---
@@ -47,13 +47,14 @@ then
if [ $s -gt 2 ]
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34588816
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
@@ -35,10 +35,9 @@ def load(self):
self.new_config.app
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34586102
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y --fo
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34578120
--- Diff: systemvm/patches/debian/buildsystemvm.sh ---
@@ -375,8 +375,10 @@ packages() {
chroot . apt-get --no-install-recommends -q -y --force-yes
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34579656
--- Diff:
systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ ---
@@ -47,13 +47,14 @@ then
if [ $s -gt 2 ]
then
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/587#discussion_r34579273
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
@@ -35,10 +35,9 @@ def load(self):
self.new_config.append(lin
12 matches
Mail list logo
