[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/559#issuecomment-118868287 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/559#issuecomment-118848092 Hi @DaanHoogland and @karuturi I did some refactoring and added more tests in order to cover both success/failure cases. Thanks for the fee

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/559#discussion_r33925325 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -1320,1

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/559#discussion_r33923859 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -1320,14 +1322

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/559#discussion_r33922730 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -1320,1

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/559#issuecomment-118798645 @wilderrodrigues Thanks for the detailed description in the pull request. It really helps :) --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-06 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/559#discussion_r33921332 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java --- @@ -1320,14 +1322

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/559#issuecomment-118516112 Hi @wilderrodrigues awesome work, thanks! LGTM (let's wait for Travis now to be sure...) --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-8607 - As an Operator I want t...

2015-07-04 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/559 CLOUDSTACK-8607 - As an Operator I want to be able to change the host password on the host itself via the updateHostPassword API The changes in this PR will cover the following: