Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-124075403
Creating 2 VMs via cloudmonkey
(local) ðµ > deploy virtualmachine displayname=isovm
networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d
templateid=285
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-124048910
Okay, guys... never mind.
I see now that I have to set 2 new values, not just one.
---
If your project is set up for it, you can reply to this email
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-124045612
Hi guys,
I tested the PR and it works fine. Below the steps I followed:
1. Change configuration option
2. create a new user account
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-124036937
Perhaps a bit more of detail on the PR description, like test steps.
I had to look at the diff of the code in order to find the new
configuration key
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-123996760
@wido @DaanHoogland @borisroman @runseb
I will test it manually before proceeding with a merge. I will also add an
integration test for that and sen
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-122299939
@wido same as @DaanHoogland here, ideal case we would have marvin
testsâ¦but...
---
If your project is set up for it, you can reply to this email and have your
repl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-122212266
Wido, I want tests but if three other people want to merge it I'm not going
to stand between them and the repo on my own.
---
If your project is set up for it,
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-122211686
Since this one got 3 LGTM's but there are outstanding test requests, how to
proceed? Do I merge it or wait for the tests?
---
If your project is set up for it, you can
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-122189103
LGTM.
Yes some tests would be good to validate expunge/recover behavior when the
config is set to true/false for an account
---
If your project is set up f
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121954927
LGTM
A test would be welcome indeed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121928759
no comments on the code but cna you describe and add tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121843328
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/589
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121600559
Added description to title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/593#issuecomment-121585809
Can you add the description of the functionality is short to the pr title?
for instance 'CLOUDSTACK-8580: user access to deleted VMs'
---
If your proje
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/593
CLOUDSTACK-8580
Users are now able to view, expunge and recover their vm's themselves. Two
configuration options are added to allow this behaviour on a global or per
account scale. Configura
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/589#issuecomment-121414567
The pull request is against the 4.5 branch while it should be against the
master branch. We can't merge it into 4.5.
Also, you seem to change more then the issu
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/589
CLOUDSTACK-8580
CLOUDSTACK-8580 Users are now able to view, expunge and recover their vm's
themselves. Two configuration options are added to allow this behaviour on a
global or per account
19 matches
Mail list logo
