Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/507#issuecomment-119083411
first let us not limmit the LTGM to commiters in the case of integration
tests. As for information, we will have to ask for it. Finally I want for us to
have a
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/507#issuecomment-119082808
Fair enough. I'm just asking because it should be made clear on the list.
It's already difficult to get 2 LGTM on the Java stuff, not many people
loo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/507#issuecomment-119082514
I have let Gaurav take care of things before because he was the only one
actually looking. I don't think we can afford to demand 2 LTGM on integration
tests. I
GitHub user nitt10prashant reopened a pull request:
https://github.com/apache/cloudstack/pull/507
CLOUDSTACK-8577: fixing script testpath_disable_enable_zone
disable enable cluster ... === TestName: test_01_disable_enable_cluster |
Status : SUCCESS ===
ok
disable enable hos
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/507#issuecomment-119082107
@DaanHoogland @runseb @bhaisaab @remibergsma
Does the LGTM idea also apply to integration tests?
Cheers,
Wilder
---
If your project is
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
LGTM. I am taking this patch.
On Mon, Jun 22, 2015 at 6:26 PM, nitt10prashant wrote:
> GitHub user nitt10prashant opened a pull request:
>
> https://github.com/apache/cloudstack/pull/507
>
> CLOUDSTACK-8577: fixing script testpath_disable_enable_zone
>
> disable enable cluster ... =
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/507
CLOUDSTACK-8577: fixing script testpath_disable_enable_zone
disable enable cluster ... === TestName: test_01_disable_enable_cluster |
Status : SUCCESS ===
ok
disable enable host
