Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/536
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/536#issuecomment-117600568
I guess a better fix needs to be worked on, closing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/536#discussion_r33651106
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -203,9 +201,22 @@ public void execute() {
ho
Github user serverchief commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/536#discussion_r33648388
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -203,9 +201,22 @@ public void execute() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/536#discussion_r33625103
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -203,9 +201,22 @@ public void execute() {
ho
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/536#issuecomment-116744035
@serverchief IMO ideally we should not be returning username/passwords. One
can use config management systems to update their host passwords and use
updateHost API
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/536#discussion_r33479990
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -203,9 +201,22 @@ public void execute() {
ho
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/536#issuecomment-115915514
Hi Rohit,
Both username and passwords are needed, and we don't want to remove them
and we would like to know what they are, however, it would be great if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/536#discussion_r33399534
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java ---
@@ -203,9 +201,22 @@ public void execute() {
ho
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/536#issuecomment-115751581
I'm not sure where the host details are getting consumed as there are many
APIs using the HostResponse class, so the safest fix was to filter out
sensitive details
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/536
CLOUDSTACK-8566: Filter sensitive details from listHosts API
Removes any username and password host details from the listHosts API
response
before it's wired back to a client.
You can merg
11 matches
Mail list logo
