Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-113046025
Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112917890
@anshul1886 would the following satisfy your needs (had some extra time)
+} else {
+if (isOutOfBandMigrated(opaque)) {
+
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112794173
travis timeout, will ignore again. hoping the pull request builder does
better.
@resmo to 4.5 yes, to master no. master has persistant config and router
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112762271
@DaanHoogland thanks for picking it up, btw do you port plan to fix it in
4.5 and master as well?
---
If your project is set up for it, you can reply to this email a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112686118
@remibergsma makes sense, will do
@anshul1886 feel free to amend, I do not consider your proposed extension
part of this blocker though it makes perfect sens
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112649249
We should generate alert when out of band router VM migration is detected.
This will help user take appropriate action in those scenarios.
---
If your project is
Thanks for picking this up!
LGTM, I'll try to test it tomorrow.
One comment: I'd propose the setting name to reflect 'out of band'. Now it
looks like when you migrate a router in ACS it will also reboot.
router.reboot.when.outofband.migrated?
Regards, Remi
Sent from my iPhone
> On 16 Jun
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/466
CLOUDSTACK-8545 make reboot on out of band migration configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudsta
