Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/357#issuecomment-112739213
@bhaisaab unit test added, won't test this other then integrally with the
suits at hand
---
If your project is set up for it, you can reply to this email and h
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/357#issuecomment-112737127
accidentally added another commit by rebasing on it. trying to fix now
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/357#issuecomment-112015264
H @bhaisaab not done writing a unit test yet. It is on my list so but it
seems fairly trivial so feel free to merge if you like it like this.
---
If your proje
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/357#issuecomment-111468328
LGTM, any test results?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/357
CLOUDSTACK-8537 add check for unique public key on registration
tests are following but need a manager refactor:(
You can merge this pull request into a Git repository by running:
$ gi
