Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-108429690
Seems to me when we have something like this, we need to add Travis test.
Otherwise we are merging something that failed the TravisCI tests. bad practice.
---
If you
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-108335819
np. Thanks for testing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-108230791
@karuturi , my apologies for not coming back earlier. :)
It worked fine. I just forgot to merge and now came back to the tab I left
open and saw thay
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-106904868
LGTM, @wilderrodrigues since you're testing please merge once it's green on
your side. Thanks @karuturi
---
If your project is set up for it, you can reply to thi
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-106782174
@karuturi
Will start testing now. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/321#issuecomment-106681254
@wilderrodrigues thank you :)
There isnt any marvin test. But, to test it manually, reduce the cleanup
thread interval to a very low value(may be 10 sec) an
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/321
CLOUDSTACK-8525: NPE while updating the state of the volume after deletion
The volume is already deleted (may be by the cleanup thread) and hence
the NPE. Added a not null check for the volu
