[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134664222 @kishankavala Thanks, that would be great! Let me know if I can be of any help. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134636230 @remibergsma changes looks fine. I would like to test it and get back to you, hopefully by tomorrow. --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/731#discussion_r37874182 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -699,17 +698,6 @@ public boolean configu

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/731#discussion_r37855588 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -699,17 +698,6 @@ public boolean configure(

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/731 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134523092 Thanks for testing and verifying @karuturi :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134502526 This is what I have done to test installed a fresh setup with centos63 rpms on MS with 6.3 and KVM host with 6.3. verified that systemvms, VR and user

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134363088 @bhaisaab No worries, took me some time as well to understand how it is supposed to work and I'm also still learning. In the Jira issue you mention two i

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134211424 Squashed some commits that belong to each other. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134169583 just to clarify I've not tested this against a real env, just reviewed the code; there are few cgroup related things I don't completely grok but I'll invest time on

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134154979 @borisroman @bhaisaab Thanks for testing! I'll have another look at the commits and see if it makes sense to quash some of them together (I'll make them

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134107765 @remibergsma looks good, but let me test it and get back to you on this; also for a small patch a single commit is preferred as multiple commits dilute the main mot

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-24 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/731#issuecomment-134071270 LGTM -> Deployed on Centos7 started 2 systemvms, 1 router and 1 guest vm without libvirt errors. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-8443: Support CentOS 7 as KVM ...

2015-08-23 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/731 CLOUDSTACK-8443: Support CentOS 7 as KVM hypervisor This adds support for CentOS 7 as a KVM hypervisor. As discussed in the Jira issue, the root cause of the issue was the `cloudstack-setup-