[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-216185889 tag:vmware-pickup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-08-09 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-129227064 Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-08-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-129041806 @likitha Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34769880 --- Diff: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java --- @@ -172,7 +175,11 @@ public DataObject

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34769780 --- Diff: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java --- @@ -172,7 +175,11 @@ public DataObject cr

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34767845 --- Diff: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java --- @@ -172,7 +175,11 @@ public DataObject

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34767796 --- Diff: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java --- @@ -172,7 +175,11 @@ public DataObject

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34767521 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-121883348 This seems to me to be a solution for vmware for a more generic problem. in the generic code conditions for hypervisortype == vmware are set while the problem i

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34767146 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1120,14 +1123,60 @@ public void cleanupStorage(boolean recurring) {

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/540#discussion_r34767004 --- Diff: engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java --- @@ -172,7 +175,11 @@ public DataObject cr

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/540#issuecomment-121854348 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

2015-06-29 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/540 CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin… …d partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete co