[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/186#issuecomment-95254152 @xenserverarmy @agneya2001 the latest update I did was to flush iptables rules before setting up ipset rules, this removes ipset references so easier to remove old i

[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-21 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/186#issuecomment-95016103 Reviewed it, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-21 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/186#issuecomment-94911018 @xenserverarmy thanks Tim for a quick review, I've fixed the case you've mentioned. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-21 Thread xenserverarmy
Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack/pull/186#issuecomment-94880329 This looks solid, but I'd update line 457 to tick-quote the vmchain as you've done elsewhere --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8395: vmops plugin should work...

2015-04-21 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/186 CLOUDSTACK-8395: vmops plugin should work on both XS 6.5 and 6.2 :fist: This fixes the issue of Security Groups not working in case of XenServer 6.5; - Uses nethash ipset data-structure to