Github user pritisarap12 closed the pull request at:
https://github.com/apache/cloudstack/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-99002486
Done with rebasing the branch with upstream master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-0495
Will review remaining changes tomorrow. A quick question, running the test
suite should not leave anything behind in the setup. Is this taken care of?
---
If y
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27651210
--- Diff: test/integration/testpaths/testpath_volume_recurring_snap.py ---
@@ -0,0 +1,1015 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650780
--- Diff: test/integration/testpaths/testpath_volume_recurring_snap.py ---
@@ -0,0 +1,1015 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650755
--- Diff: test/integration/testpaths/testpath_volume_recurring_snap.py ---
@@ -0,0 +1,1015 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650534
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -1771,17 +1666,17 @@ def
test_03_migrate_root_and_data_disk_nonlive_cwps_v
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650484
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -765,7 +597,7 @@ def test_01_migrate_root_and_data_disk_nonlive(self):
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650440
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -659,11 +478,11 @@ def test_01_migrate_root_and_data_disk_nonlive(self):
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650373
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -536,8 +353,10 @@ def test_01_migrate_root_and_data_disk_nonlive(self):
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r27650336
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -479,6 +283,19 @@ def setUpClass(cls):
)
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26833819
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -1395,3 +1396,218 @@ def isNetworkDeleted(apiclient, networkid,
timeout=600):
time.s
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26833788
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -1395,3 +1396,218 @@ def isNetworkDeleted(apiclient, networkid,
timeout=600):
time.s
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26833707
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -1143,9 +1149,6 @@ def register(cls, apiclient, services, zoneid=None,
elif "projectid"
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26833696
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -1086,7 +1092,7 @@ def create(cls, apiclient, services, volumeid=None,
@classmethod
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-83990945
Integrated review changes:
Testcase result:
Test Volume (root) Snapshot ... === TestName: test_01_volume_snapshot |
Status : SUCCESS ===
ok
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-83533242
Also please add the test case execution results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26748307
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -1395,3 +1399,199 @@ def isNetworkDeleted(apiclient, networkid,
timeout=600):
time.s
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26748285
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -1395,3 +1399,199 @@ def isNetworkDeleted(apiclient, networkid,
timeout=600):
time.s
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26748249
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -1395,3 +1399,199 @@ def isNetworkDeleted(apiclient, networkid,
timeout=600):
time.s
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-83436486
Hi Rohit,
I am yet to review updated pull request.
Regards,
Gaurav
On Thu, Mar 19, 2015 at 2:22 PM, Rohit Yadav
wrote:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-83426630
@gauravaradhye is it good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301600
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301554
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301742
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301316
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301476
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301332
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301374
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,745 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26301214
--- Diff: test/integration/smoke/test_vm_snapshots.py ---
@@ -16,14 +16,16 @@
# under the License.
--- End diff --
This file seems
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/117#discussion_r26293221
--- Diff: test/integration/testpaths/testpath_volume_snapshot.py ---
@@ -0,0 +1,744 @@
+# or more contributor license agreements. See the NOTICE file
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/117#issuecomment-78451273
@pritisarap12 looks good, but not a test guru to review/merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/117
CLOUDSTACK-8380: Adding automation test cases for VM/Volume snapshot
testpath
CLOUDSTACK-8380: Adding automation test cases for VM/Volume snapshot
testpath
You can merge this pull request
33 matches
Mail list logo
