Github user srikanteswartalluri closed the pull request at:
https://github.com/apache/cloudstack/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129546119
Folks,
i am closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
-1
Without changes it works fine, because if we don't specify the "enabled"
attribute for the zone in the config file, it will enable the zone by default.
Even
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129040590
@srikanteswartalluri Any update on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-127891937
enabled = enabled if enabled else 'true'
will set enable to true if enable is false or None which is unexpected,
ideally enable should be false i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-120371884
I don't see that the travis failures are related to this code but the
change is not so significant that push through makes sense. Would be nice to
have quick it
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/158#discussion_r34343974
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -790,8 +790,13 @@ def createZones(self, zones):
self.createPrimarySt
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-117979550
@gauravaradhye can you review this ? @srikanteswartalluri looks like Travis
failed.
---
If your project is set up for it, you can reply to this email and have your
r
GitHub user srikanteswartalluri opened a pull request:
https://github.com/apache/cloudstack/pull/158
CLOUDSTACK-8379:add support to marvin to enable deployed zone based on t...
...he value provided in config file
You can merge this pull request into a Git repository by running: