Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/166#issuecomment-92825534
in cases like this, make sure to squash commits. and if pep8 does not pass,
then ask for revision to PR
---
If your project is set up for it, you can reply to this em
Sure Sebastien, I missed squashing. Thanks.
Regards,
Gaurav Aradhye
On Apr 14, 2015, at 6:50 PM, runseb wrote:
> Github user runseb commented on the pull request:
>
>https://github.com/apache/cloudstack/pull/166#issuecomment-92825534
>
>in cases like this, make sure to squash commits.
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/166#issuecomment-92815608
This is committed. Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gauravaradhye closed the pull request at:
https://github.com/apache/cloudstack/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/166
CLOUDSTACK-8374: Adding tests for guest traffic port group verification -
Shared and Isolated networks
For Isolated network, network and VM is already created in setUpClass, so
only addi
