[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-04 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-89627323 Thanks Rohit. Closed now. On Apr 4, 2015, at 2:20 PM, Rohit Yadav wrote: > Looks like already merged c05e37b, but the merger did not add the "This

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-04 Thread gauravaradhye
Github user gauravaradhye closed the pull request at: https://github.com/apache/cloudstack/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-89530067 Looks like already merged c05e37b28d9eae73e09a679a8725a6fd09a03b2b, but the merger did not add the "This closes #138" string. Please close now. --- If your proj

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-01 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-88421582 Done. Regards, Gaurav On Wed, Apr 1, 2015 at 3:20 PM, Srikanteswararao Talluri < notificati...@github.com> wrote: > Looks good.

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-01 Thread gauravaradhye
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-88421366 Rebased with latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-01 Thread srikanteswartalluri
Github user srikanteswartalluri commented on the pull request: https://github.com/apache/cloudstack/pull/138#issuecomment-88418770 Looks good. Can you rebase it with latest master? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8356: Mentioning netaddr modul...

2015-04-01 Thread gauravaradhye
GitHub user gauravaradhye opened a pull request: https://github.com/apache/cloudstack/pull/138 CLOUDSTACK-8356: Mentioning netaddr module in setup.py in marvin as it is used across test cases The netaddr module is used in various test cases but it is not mentioned in setup.py file.