Hi Remi,
I’m not sure why but sometimes the asfgit hook fails to close a PR. In that
case I general ask the PR author to close it manually. I had manually closed
the PR #288.
> On 25-May-2015, at 2:26 pm, Remi Bergsma wrote:
>
> Hi Rohit,
>
> Just merged your PR to 4.5 and the commit is shown
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105225714
Merged on 4.5, so closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105225663
Thanks @remibergsma I'll merge it on both 4.5 and master. On master, I'll
need to fix the packaging.
---
If your project is set up for it, you can reply to this em
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105225393
For documentation purposes: the PR is merged and commit is here in 4.5:
https://github.com/apache/cloudstack/commit/d2b0c1a32b2d8719eafd6d4574de9a824d46d290
---
Hi Rohit,
Just merged your PR to 4.5 and the commit is shown here. LGTM.
https://github.com/apache/cloudstack/commit/d2b0c1a32b2d8719eafd6d4574de9a824d46d290
It’s just that your PR did not get closed. Is there anything I should have done
to make this happen?
Thanks for the advice.
Regards,
Rem
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105224256
@bhaisaab Tested with non-privileged user (now uses sudo) and with root
user (does not use sudo) and both just add the host as one would expect.
As user
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105205488
@remibergsma thanks, I tested locally and it seems to be working for me
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105205213
@bhaisaab Awesome, will give it a final test run soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105201247
Thanks for commenting @mlsorensen @remibergsma
In the new fix we're maintaining old behavior for root users by not adding
sudo, I've updated the install docs wi
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105173698
I'm focussing on getting this sorted out so we can merge.
@mlsorensen I like the idea of not changing anything in case the username
is 'root'.
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105133656
The issue now is that root credentials for the host are stored in the db,
and even echoed back if you ask to list hosts with details. It's a huge step
forward to
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105115006
For now, I think the quick win is to make the proposed use of 'sudo' work,
so that works what worked before (we require root credentials to add a host)
and alter
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105076586
On Mon, May 25, 2015 at 12:50 AM, Rafael da Fonseca <
notificati...@github.com> wrote:
> Creating a user for this use would be worse, because it would r
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105073554
Creating a user for this use would be worse, because it would require some
sort of 'standard' credential for ssh access. Or it would require that such
account did
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105072838
Thanks for reviewing everyone. Regarding the tty/sudo issue, I'll test and
see if we can fix something in the agent post installation or setup scripts
similar to wh
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105064856
Why don't we make a dedicated user (be it 'cloud' or anything) during agent
install time?
Makes a lot more sense to me, than relying on the usage of 'ro
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105063069
Silly me.. this is running as supplied user, not as cloud. I agree remi,
ssh -t is the better option :)
---
If your project is set up for it, you can reply to th
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105056903
Hi @remibergsma
If you're running into the no tty issue, that will likely happen also for
the other commands the management server tries to run.
I'm using
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105045696
@bhaisaab, I tested your patch and ran to an issue where a TTY is required
to run sudo, but not requested. The host cannot be added.
Logs:
```
20
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105031461
Oh, I see the original post mentions that!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105031405
Note you still have to add a sudoers entry for the user to run
cloudstack-setup-agent.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+non-r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/288#issuecomment-105004714
@bhaisaab Nice! The code LGTM, will give it a test-drive today or tomorrow
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/288
CLOUDSTACK-8339: Allow non-root users to add KVM host
This allows non-root users to add KVM hosts, the user should be an admin or
added to sudoers to execute sudo cloudstack-setup-agent.
Yo
24 matches
Mail list logo
