[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-09 Thread rags22489664
Github user rags22489664 closed the pull request at: https://github.com/apache/cloudstack/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77809892 As per rest of the design, all the managers generally implement the response generators. The fix that was pushed follows same convention/design. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-08 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77741942 I don't mind. I'm just worried about the rammifications for the API design. I stole my implementation from somewhere else. It must have once been decided th

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-08 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77739908 Hi @DaanHoogland your fix looks good as well, though the fix @rags22489664 suggests or that one I did would solve for the create response method in the manager implem

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77703465 I solved this privately and forgot to give back to the community. Please consider this solution @bhaisaab . It seems to be custom for these @transient-annotated f

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77596535 Scks that I missed this PR couple of days ago. I though @DaanHoogland was reviewing it. Okay, I made a similar fix thanks for the effort @rags22489664 but you may clo

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-02-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-75833513 I recognize the problem and did some code to implement it in the response generation. might be this didn't make it to any release yet. Have a look at ListNetworkA

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-02-24 Thread rags22489664
GitHub user rags22489664 opened a pull request: https://github.com/apache/cloudstack/pull/87 CLOUDSTACK-8280: UI does not display source CIDR in VPC ACL Since https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b0c34f, the source cidr for acl rules are not dislpayed in the U