Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117815608
Yep... Agree.
That's what I also suggested in my reply.
We are getting better... Next one will be perfect. :)
Thanks, guys!
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117813307
I agree, ticket id is enough.
Sent from my iPhone
> On 01 Jul 2015, at 21:35, Miguel Ferreira
wrote:
>
> @wilderrodrigues @remibergsm
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117802350
@wilderrodrigues @remibergsma @bhaisaab why not just put the the ticket ID
in the commit message?
something like:
* CLOUDSTACK-8180: adding this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117646467
@wilderrodrigues LGTM, meld the commits to one maybe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117583894
@remibergsma
I also think it's a bit annoying the commits with the same message, but we
have to inform the jira issue.
Next time I will add
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/549#issuecomment-117576939
Thanks for fixing it, LGTM.
Small comment: I see two commits with the same first line. Personally I'd
prefer to see from the first line what a commit implemen
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/549
CLOUDSTACK-8180 - RouterVM does no longer provide X-ForwardedFor header
with Loadbalancer
Hi @remibergsma and @DaanHoogland
The "option forwardfor" in the haproxy has been fixe
