[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76372764 Yes they are :) I generally try to fix things starting from lowest branch where the fix is applicable. --- If your project is set up for it, you can reply to this em

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread Erik Weber
On Fri, Feb 27, 2015 at 10:41 AM, Nux! wrote: > Thanks for clarification, Erik. > So using custom db names should be avoided as much as possible. > > I've never tried, so I don't know how much work it would require to get working. It's certainly not impossible, but it might not be easy either :-)

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread Nux!
, 2015 09:22:40 > Subject: Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute > schema refe... > On Fri, Feb 27, 2015 at 10:15 AM, Nux! wrote: > >> Hi, >> >> "Hardcoding" the name is not a very good idea, I understand that under the >&g

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread Erik Weber
On Fri, Feb 27, 2015 at 10:15 AM, Nux! wrote: > Hi, > > "Hardcoding" the name is not a very good idea, I understand that under the > circumstances is OK, but still. > > We have to be aware of this detail as there could be people using another > name for their DB (I did this in the past). Would up

Re: [GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread Nux!
ntioned in the release notes. Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "bhaisaab" > To: dev@cloudstack.apache.org > Sent: Wednesday, 14 January, 2015 14:58:22 > Subject: [GitHub] cloudstack pull reques

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76359249 ok all good then , just want to make sure we get in the habit of merging these in all forward release branches. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76358975 @runseb * 4.5 https://github.com/apache/cloudstack/commit/7885a6c4efe13a07b3966ef8684152dda5108f8b * master https://github.com/apache/cloudstack/commit/396936ea

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76357813 @bhaisaab has this been ported to 4.5 and master ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76355991 @bhaisaab Seems I overlooked the fix yesterday. All good in 4.4 branch. never mind. --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76346065 Good to know @resmo I think I had cherry-picked Erik's fix on 4.3+ branches. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-26 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76288584 @bhaisaab This also fails on cloudstack 4.4.2 on debian 7. fix worked. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/67 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-69928504 Thanks for fixing this Erik @terbolous ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-69927724 Fair point, merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-69927499 Yes, that would also work. I considered it, but since the file works with both cloud and cloud_usage I wasn --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-69926942 LGTM. Maybe we could be to put "USE cloud;" (or cloud_usage as applicable) in this file at the beginning, will that help? --- If your project is set up for it, you c

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-01-14 Thread terbolous
GitHub user terbolous opened a pull request: https://github.com/apache/cloudstack/pull/67 CLOUDSTACK-8157: Add absolute schema references to support MySQL 5.6 better This should fix the problem some people are seeing with cloudstack-setup-databases complaining about 'No database sel