[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1222 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-12 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164127045 Awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164126939 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164065917 LGTM :+1: Ran tests on Ubuntu 14.04 ```Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_r

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164019927 I have started the integration tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164018739 Ping @DaanHoogland @remibergsma @miguelaferreira @borisroman @davidamorimfaria Tests have been executed again and all looks fine! ```

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164016942 This where and why the vpc vr refactor started, isn't it? code lgtm, let's have a regression test and put it in! --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164008050 Ping @remibergsma @DaanHoogland @miguelaferreira @borisroman @michaelandersen One test failed due to a network hiccup. I will run only that test aga

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-11 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/1222 CLOUDSTACK-4374 - As a Developer I want to have HA enabled for routers that are part or a redundant network or VPC This PR fixes the issue we were facing with crashed redundant routers