Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-218186983
This one is good to go. The connectivity issue is related to my
environment. I reran the password test and it passed the second time, so that
is not a problem eithe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-218179272
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 37m 42s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-216227189
I can prioritize CI on this one as it is ready otherwise. It is worth
doing a test run since a lot has happened since this was rebased. Thx...
---
If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-216205563
@rafaelweingartner please rebase against master and update on status of
your PR?
Looks like this can be merged once CI tested by @swill
tag:easypr
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-207540194
@swill, @DaanHoogland
What about this one?
I have just rebased it.
---
If your project is set up for it, you can reply to this email and have you
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-188794542
That is right, sorry I did not pay much attention.
I will be waiting his answer
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-188790451
@rafaelweingartner , There is a question addressed to @remibergsma awaiting
answer. Other then that, yes.
---
If your project is set up for it, you can reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-188772285
@DaanHoogland what do you think about this one ?
Tests were executed, reviews done.
I think we forgot it, should we go ahead and merge it?
---
If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-176045950
@rafaelweingartner thanks; @remibergsma should we let this be merged
considering your integration test result, or you want to re-run them?
---
If your project is
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-175849683
@bhaisaab rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-175683387
LGTM, @rafaelweingartner can you please rebase against latest master so we
can merge this
---
If your project is set up for it, you can reply to this email and ha
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-162230888
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-160603505
I was thinking about that. Starting in January we will have some extra
time, then we might have a look at that.
---
If your project is set up for it, you
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-160568739
@rafaelweingartner there has been lots of discussion on the list about
testing. The TravisCI setup is supposed to do part of it, and we can also
trigger the tests as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-159743630
I have being wanting to ask you guys about those integration tests. Isn´t
it possible for us to run those tests automatically every time a PR is created
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-159743067
LGTM: less is more, an integrations test run on it is of course the
minimum. @remibergsma can you queue it?
---
If your project is set up for it, you can repl
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/1124
CID-1338387: Deletion of method endPointSelector.selectHypervisorHost
Following the discussions and analysis presented on PR#1056 create by
@DaanHoogland
This PR is intended to pu
18 matches
Mail list logo
