Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-221758314
This is a cleaner run because this issue is a known issue. I think this
one is ready now...
---
If your project is set up for it, you can reply to this email and hav
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-221757982
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 33m 42s
```
**Summary of the pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-221633655
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 1
Duration: 10h 41m 55s
```
**Summary of the p
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220939007
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64197154
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
sc.ad
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r64195431
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220935383
@swill rebased with latest master
@GabrielBrascher fixed the typo
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220513570
@kishankavala please rebase this PR as we have merge conflicts. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-216191410
@kishankavala please rebase against latest master and push -f, update on
status of your PR
I've left a NPE check, we should merge it once you fix that. Thanks.
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r61724005
--- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ---
@@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp) {
sc.ad
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-213034173
Thank you @GabrielBrascher. @kishankavala would you mind fixing that typo?
I will try to get this run though CI soon...
---
If your project is set up for it, you ca
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-212999101
Although I had pointed a typo in a comment line (nothing serious), the code
LGTM.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-212983883
I need one more LGTM. I will add this to my CI queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user rajesh-battala commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-212782054
I have gone through the code. patch LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r52110260
--- Diff: server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java
---
@@ -342,6 +342,12 @@ public ExternalDeviceNetworkUsageTask() {
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-173198529
Ping @remibergsma @borisroman
@kishankavala added a unit test to cover his change. I went through the
code and haven't found any issue.
The
GitHub user kishankavala opened a pull request:
https://github.com/apache/cloudstack/pull/846
Bug-ID: CLOUDSTACK-8870: Skip external device usage collection if no
external devices exist
external network device usage monitor thread that runs every 5mins by
default (based on global c
18 matches
Mail list logo
