[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150588016 @DaanHoogland Sounds good. I'll hold off. Thanks for the help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150585840 @dmabry I am already writng a combination. please review when done --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150582452 I'll take a look at #812 and see about combining them into this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150553318 Agreed with @remibergsma, but the code-wise this is a LGTM. One PR which includes #812 as well would be nice. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/966#issuecomment-150546240 See also PR #812 and the comments there. Can anyone combine the two and address the comments in PR #812 please? If it can be done soon, we can merge it in 4.6. T

[GitHub] cloudstack pull request: Added support for KVM teamd devices to Li...

2015-10-22 Thread dmabry
GitHub user dmabry opened a pull request: https://github.com/apache/cloudstack/pull/966 Added support for KVM teamd devices to LibvirtComputingResource.java This will allow KVM users to utilize teamd nic teaming devices named team*. You can merge this pull request into a Git reposit