Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125886503
LGTM except one small change suggested.
Please don't mix intended changes and pep8 fixes, you can add another
review request for pep8 fixes subsequently. Th
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/632#discussion_r35739964
--- Diff: test/integration/smoke/test_snapshots.py ---
@@ -123,65 +126,78 @@ def test_01_snapshot_root_disk(self):
#the reqd volume
Github user manasaveloori commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125886157
@DaanHoogland
This is just an enhancement to existing test in the script.
The output is from nose test result of the script.
---
If your project is se
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/632#issuecomment-125884841
@manasaveloori can you give us the command to which this output fits?
@gauravaradhye can you review this, please? (looks like a lot of code to me)
---
GitHub user manasaveloori opened a pull request:
https://github.com/apache/cloudstack/pull/632
Added a test to verify that listSnapshots response returns zone id
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk |
Status : SUCCESS ===
ok
-
