[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread miguelaferreira
Github user miguelaferreira closed the pull request at: https://github.com/apache/cloudstack/pull/947 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149201734 I've made two PRs (#946 and #947) that are actually interdependent, so I'll close both and make a new one that combines the two. --- If your project is set

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149172742 Indeed we cannot ship this dependency, however we can and have been using it in development. As long as we don't enable the developer profile when we build t

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149170965 wasn't there an issue about the license of this connector some time back? What's the current license ? is it ASF compliant ? --- If your project is set up for it,

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149170612 @DaanHoogland automation, automation, automation ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/947#issuecomment-149166994 LGTM, only visual, i will run it in the bubble but the queue is now grown over 10 PRs :( --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Add MySQL connector dependency to develop...

2015-10-19 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/947 Add MySQL connector dependency to developer profile The most common way to run the management server while developing is to start up Jetty via maven. However, in a continuous integration