Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1555
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221759242
This is ready to merge now. The issue we are seeing is a known issue not
related to this PR.
---
If your project is set up for it, you can reply to this email and h
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221759081
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 37m 16s
```
**Summary of the p
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221572152
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221497756
I add the noprompt option. Travis&Jenkins are green. Ready to merge.
cc @swill @footplus
---
If your project is set up for it, you can reply to this
Github user footplus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64432411
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -204,6 +203,7 @@ if [ -f "$customCACert" ]
then
keytool -delete -alias $aliasName -keystore $
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324840
Thanks for the update. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378
Hum, please wait a bit before merging, it seems that in certain cases, a
problem occurs; I'm not sure yet, but there may be more to it.
I'll double check w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159974
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221159912
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 55m 13s
```
**Associ
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220882622
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220784860
I've fixed the English messages.
All is green. LGTM level reached. Ready to merge.
cc @swill
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778699
the message is not in good English, other then that LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134782
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realho
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134773
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
- printf "priv
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220778455
It seems that even without a custom SSL cert, one needs this PR to be able
to download from other https sites (as the realhostip one is always loaded).
---
If
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64134745
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realhos
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220771292
ping @ustcweizhou , does this suit Leaseweb?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132615
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -123,6 +123,8 @@ customCACert=
publicIp=
hostName=
keyStore=$(dirname $0)/certs/realho
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64132608
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -167,7 +169,7 @@ then
fi
if [ ! -f "$customPrivKey" ]
then
- printf "pri
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220767434
Thanks @milamberspace! I was also looking into this and hacked around a
bit. Your solution is nice! Now when a custom cert is used, the other CAs are
also avail
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220764639
Travis & Jenkins are green. Ready for 2 x LGTM (easy review)
cc @DaanHoogland @rhtyd
---
If your project is set up for it, you can reply to this ema
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734
LGTM :) It seems to work correctly on my 4.8.0 setup.
Thanks.
Best regards,
Aurélien
---
If your project is set up for it, you can reply to
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1555
Add Java Default Certificat Authorities into the keystore if using a custom
cert SSL
Related to CLOUDSTACK-1475
You can merge this pull request into a Git repository by running
24 matches
Mail list logo
