Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215081538
Thank you gentlemen. I think this one is ready now. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215048942
LGTM, i had run the tests as well, with no more then the usual problems
&*%(^%. Note that part of the change is mine when you take my lgtm for it;)
---
If you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214999606
Compiled the code using JDK8 (1.8.0_65) and ran unit tests, works on my
system.
Based on the code changes: LGTM
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214992687
@DaanHoogland @wido @jburwell review/lgtm please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214965449
This one is ready pending at least one LGTM vote...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214960615
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
**
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214620580
@swill thanks, this can be merged first as we wait for bountycastle related
changes to work with openjdk 1.7.0_95+
---
If your project is set up for it, you can repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214480409
go ahead. I am trying to get to the bottom of marvin being strange right
now.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214480008
@swill busy on this one yet? I am looking to run it as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213558371
@bhaisaab @swill it is important to note that Spring 3 only supports
running JDK8 for applications built using a target version of 1.7.
Applications built using S
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213540008
@bhaisaab yep, already got it. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213521104
@swill please include this PR in your list, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213398409
With this change we would be able to use JDK8 for building cloudstack once
we fix the build issues of F5 plugin (that's the only component that fails to
build with
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1510
4.9 mvn version safeupgradeonly
Upgrades maven dependencies versions that can be safely upgraded without
breaking console-proxy/crypto usage.
Bisected changes from: https://github.com
15 matches
Mail list logo