[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78288355 @bhaisaab just a thought, but from the commit messages I can't tell the critical bug fix was applied. I think you should merge. We need the pom version switch anyway.

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78433858 Ran basic tests against KVM, they passed for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread sebgoa
On Mar 12, 2015, at 7:11 AM, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > >https://github.com/apache/cloudstack/pull/112#issuecomment-78429050 > >@runseb So we've two options: > >I merge this into 4.5 and then a 4.5.1 RC1 candidate is cut off 4.5 > bran

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78429111 @runseb yes, I want a linear release too; just use latest 4.5 (after we merge this). I'm testing it now and then merging if it passes. --- If your project

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78429050 @runseb So we've two options: I merge this into 4.5 and then a 4.5.1 RC1 candidate is cut off 4.5 branch. On 4.5 branch there aren't many commits that have w

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78300415 On Mar 11, 2015, at 5:09 PM, Rohit Yadav wrote: > @runseb the bugs were fixed on 4.5 branch so they are already in 4.5 branch. I think to create 4.5.1 RC

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78295147 @runseb the bugs were fixed on 4.5 branch so they are already in 4.5 branch. I think to create 4.5.1 RC one could simply branch off from 4.5 once these commits are m

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78252001 Build fine with all unit tests passing, upgrade runs successfully from 4.5.0. cc @ke4qqq @runseb @daanhoogland - would be great if you can review it --- If

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/112 4.5 Branch: update pom version and add upgrade path from 4.5.0 to 4.5.1 - Updates pom version to 4.5.1-SNAPSHOT - Adds upgrade path from 4.5.0 to 4.5.1 You can merge this pull request into