[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8677: use wrapper classe...

2016-05-02 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8677: use wrapper classe...

2016-05-02 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-216213369 I'd rather redo it then try to port forward. Testing means validating each command in an integration test. If unit testing is required; for each command and res

[GitHub] cloudstack pull request: [wip] CLOUDSTACK-8677: use wrapper classe...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/987#issuecomment-216201554 @DaanHoogland can you rebase against latest master; it's huge change, advise how to test and review it --- If your project is set up for it, you can reply to this ema