[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-173185222 When the network stack get's refactored this won't be necessary anymore. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-11-21 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-158684576 code looks good but I don't see the use case; in an isolated network without internet access there would still be a gateway, would there? --- If your project i

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-11-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-158676481 @borisroman Can you have a look and resolve the conflict? When we find another reviewer we can merge this in 4.7. Pinging @DaanHoogland @bhaisaab --- If your p

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-09-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143160853 @wido Travis passing fine now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-09-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143153417 @wido I've force pushed my last commit to let Travis rerun the tests. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-09-25 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/886#issuecomment-143148262 Seems good to me, in Basic Networking it's not always required. I see that Travis CI timed out, any reason for that? Based on the code a LGTM from me, I

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

2015-09-24 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/886 [FUTURE]CLOUDSTACK-8907: POD Gateway optional A gateway might not always be available. For instance, when the management network is an isolated network without internet access or inter domain