[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread milamberspace
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131221933 @milamberspace Could you please close this PR as @bhaisaab applied the patch to 4.5. Thanks! --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131221363 @bhaisaab Wrote a script to handle the merge and made it compatible with your 'git pr' workflow. See https://github.com/schubergphilis/cloudstack-git-t

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131043213 @bhaisaab Thanks for LGTM (Daan too) The PR for fix the master is here: (#686) https://github.com/apache/cloudstack/pull/686 Need a second

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131030116 @DaanHoogland cool, will try that in future --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131029374 @bhaisaab if you merge, preserving the commit-ids github will close this PR regardless of the branch it was merged to. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131028521 @milamberspace thanks, merged on 4.5; since this is a non-master branch you'll have to close the PR manually. Also, do we want to port this to master? --- If your

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-131028291 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/687#issuecomment-130647516 travis timeout LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [CS45] Add missing localization for some ...

2015-08-12 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/687 [CS45] Add missing localization for some labels in Web UI - on the zone configuration wizard for the "Next" button - on templates, Shared, extratable and Dynamically Scalable - Impr