Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-212902454
I think this one is ready to merge. I will add it to my merge queue...
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-212886925
@sanju1010 Have done code walk through and LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-206575399
@sanju1010 LGTM but can you force push the code again or close and open the
pr again to force a rebuild of the jenkins pr job? it has some weird failures.
I th
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1323#discussion_r58783340
--- Diff: test/integration/component/test_redundant_router_cleanups.py ---
@@ -666,3 +667,156 @@ def test_network_gc(self):
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1323#discussion_r58686721
--- Diff: test/integration/component/test_redundant_router_cleanups.py ---
@@ -666,3 +667,156 @@ def test_network_gc(self):
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-201576078
_Link to logs Folder (search by build_no):_
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
### ACS CI BVT Run
**Sumarry:**
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-173214346
:) @wilderrodrigues obviously; it is a test, @sanju1010 tested it himself,
do you want to test it in different environments?
---
If your project is set up for
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-173196099
Ping @remibergsma @borisroman
This one needs to be tested.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1323#issuecomment-170353747
LGTM. only code review done with one remark on naming of the method. Not
tested.
---
If your project is set up for it, you can reply to this email and have yo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1323#discussion_r49276570
--- Diff: test/integration/component/test_redundant_router_cleanups.py ---
@@ -666,3 +667,156 @@ def test_network_gc(self):
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1323
[CLOUDSTACK-9218]Test to verify restart network after master VR destroyed
Please refer CLOUDSTACK-9218 for more details
Test Results:
===
Test restarting RvR netw
12 matches
Mail list logo
