Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-220755087
the sweet sweet color green... ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1424
[CLOUDSTACK-8973] Fix create template from snapshot returning null in case
of region store
This PR fixes a case where when we create a template from a snpashot in a
region wide store, we don't
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-220738801
@syed: Getting close to freeze, please repush to see if we can get jenkins
green. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-219539528
@syed can you rebase and force push this one? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-218808523
@syed can you force push this one again to see if we can get Jenkins to
pass now. We have fixed some issues with Jenkins and Travis this morning.
Thx...
---
If yo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-218183611
Looking for one more code review on this one. Also, once we fix the disk
being full issue on Jenkins, I will need you to re-push this PR to kick off
jenkins so we ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-218183099
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 53m 35s
```
**Associ
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386
@rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this
one, it would be awesome!
---
If your project is set up for it, you can reply to this emai
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217460449
Can I get one more code review on this one? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217451440
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-216224725
@syed please rebase and squash changes into a single commit
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
repl
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54762401
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -275,6 +277,8 @@
private StorageCacheManager cacheMgr;
@Inject
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54762197
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -1388,7 +1388,7 @@ public TemplateResponse
createTemplateUpdateResponse(ResponseView view,
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54595010
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -275,6 +277,8 @@
private StorageCacheManager cacheMgr;
@In
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54362124
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -1388,7 +1388,7 @@ public TemplateResponse
createTemplateUpdateResponse(Re
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54362098
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -1705,6 +1709,14 @@ public VMTemplateVO
createPrivateTemplateRecord
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1424
[CLOUDSTACK-8973] Fix create template from snapshot returning null in case
of region store
This PR fixes a case where when we create a template from a snpashot in a
region wide store, we don't se
19 matches
Mail list logo
